websocketTest.js ➔ describe(ꞌChat Serverꞌ) - Code Metrics - Inspection of "fix" - ericN93/module - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1d44d5...cbfa7c )

by Eric

created 2017-12-08 09:14 UTC

websocketTest.js ➔ describe(ꞌChat Serverꞌ) B

↳ Parent: test/websocketTest.js

Complexity

Conditions	1
Paths	1

Size

Total Lines

146

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	1
c	1
b	1
f	0
nc	1
nop	0
dl	0
loc	146
rs	8.2857

6 Functions

Rating	Name	Size	Complexity
A	websocketTest.js ➔ ... ➔ it(ꞌShould broadcast new user once they connectꞌ)	16	1
A	websocketTest.js ➔ ... ➔ afterEach	3	1
B	websocketTest.js ➔ ... ➔ it(ꞌShould be able to broadcast messagesꞌ)	33	1
A	websocketTest.js ➔ ... ➔ it(ꞌShould be able to send private messagesꞌ)	47	1
A	websocketTest.js ➔ ... ➔ beforeEach	4	1
B	websocketTest.js ➔ ... ➔ it(ꞌShould broadcast new user to all usersꞌ)	33	1

How to fix Long Method

var should = require('should');
var io = require('socket.io-client'),
    server = require('../index');

var socketURL = 'http://localhost:5000';

var options ={
  transports: ['websocket'],
  'force new connection': true
};

var chatUser1 = {'name':'Tom'};
var chatUser2 = {'name':'Sally'};
var chatUser3 = {'name':'Dana'};

let request = require('supertest');


describe("Chat Server",function(){
    let server;
      beforeEach(function () {
      	delete require.cache[require.resolve('../index')];
        server = require('../index');
      });
      afterEach(function (done) {
        server.close(done);
      });
  /* Test 1 - A Single User */
  it('Should broadcast new user once they connect',function(done){
    var client = io.connect(socketURL, options);

    client.on('connect',function(data){

      client.emit('connection name',chatUser1);
    });

    client.on('new user',function(usersName){
      usersName.should.be.type('string');
      usersName.should.equal(chatUser1.name + " has joined.");
      /* If this client doesn't disconnect it will interfere
      with the next test */
      client.disconnect();
      done();
    });
  });

  /* Test 2 - Two Users */
  it('Should broadcast new user to all users', function(done){
    var client1 = io.connect(socketURL, options);

    client1.on('connect', function(data){

      client1.emit('connection name', chatUser1);


      /* Since first client is connected, we connect
      the second client. */
      var client2 = io.connect(socketURL, options);

      client2.on('connect', function(data){

        client2.emit('connection name', chatUser2);
      });

      client2.on('new user', function(usersName){
        usersName.should.equal(chatUser2.name + " has joined.");
        client2.disconnect();
      });

    });

    var numUsers = 0;
    client1.on('new user', function(usersName){
      numUsers += 1;

      if(numUsers === 2){
        usersName.should.equal(chatUser2.name + " has joined.");
        client1.disconnect();
        done();
      }
    });
  });

  /* Test 3 - User sends a message to chat room. */
  it('Should be able to broadcast messages', function(done){
    var client1, client2, client3;
    var message = 'Hello World';
    var messages = 0;

    var checkMessage = function(client){
      client.on('message', function(msg){
        message.should.equal(msg);
        client.disconnect();
        messages++;
        if(messages === 3){
          done();
        };
      });
    };

    client1 = io.connect(socketURL, options);
    checkMessage(client1);

    client1.on('connect', function(data){

      client2 = io.connect(socketURL, options);
      checkMessage(client2);

      client2.on('connect', function(data){

        client3 = io.connect(socketURL, options);
        checkMessage(client3);

        client3.on('connect', function(data){

          client2.send(message);
        });
      });
    });
  });

  /* Test 4 - User sends a private message to another user. */
  it('Should be able to send private messages', function(done){
    var client1, client2, client3;
    var message = {to: chatUser1.name, txt:'Private Hello World'};
    var messages = 0;

    var completeTest = function(){
      messages.should.equal(1);
      client1.disconnect();
      client2.disconnect();
      client3.disconnect();
      done();
    };

    var checkPrivateMessage = function(client){
      client.on('private message', function(msg){
        message.txt.should.equal(msg.txt);
        msg.from.should.equal(chatUser3.name);
        messages++;
        if(client === client1){
          /* The first client has received the message
          we give some time to ensure that the others
          will not receive the same message. */
          setTimeout(completeTest, 40);
        };
      });
    };

    client1 = io.connect(socketURL, options);
    checkPrivateMessage(client1);

    client1.on('connect', function(data){

      client1.emit('connection name', chatUser1);
      client2 = io.connect(socketURL, options);
      checkPrivateMessage(client2);

      client2.on('connect', function(data){

        client2.emit('connection name', chatUser2);
        client3 = io.connect(socketURL, options);
        checkPrivateMessage(client3);

        client3.on('connect', function(data){

          client3.emit('connection name', chatUser3);
          client3.emit('private message', message)
        });
      });
    });
  });
});


1			var should = require('should');
2			var io = require('socket.io-client'),
3			server = require('../index');
4
5			var socketURL = 'http://localhost:5000';
6
7			var options ={
8			transports: ['websocket'],
9			'force new connection': true
10			};
11
12			var chatUser1 = {'name':'Tom'};
13			var chatUser2 = {'name':'Sally'};
14			var chatUser3 = {'name':'Dana'};
15
16			let request = require('supertest');
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The variable `request` seems to be never used. Consider removing it. Loading history...
17
18			describe("Chat Server",function(){
19			let server;
20			beforeEach(function () {
21			delete require.cache[require.resolve('../index')];
22			server = require('../index');
23			});
24			afterEach(function (done) {
25			server.close(done);
26			});
27			/* Test 1 - A Single User */
28			it('Should broadcast new user once they connect',function(done){
29			var client = io.connect(socketURL, options);
30
31			client.on('connect',function(data){
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
32			client.emit('connection name',chatUser1);
33			});
34
35			client.on('new user',function(usersName){
36			usersName.should.be.type('string');
37			usersName.should.equal(chatUser1.name + " has joined.");
38			/* If this client doesn't disconnect it will interfere
39			with the next test */
40			client.disconnect();
41			done();
42			});
43			});
44
45			/* Test 2 - Two Users */
46			it('Should broadcast new user to all users', function(done){
47			var client1 = io.connect(socketURL, options);
48
49			client1.on('connect', function(data){
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
50			client1.emit('connection name', chatUser1);
51
52
53			/* Since first client is connected, we connect
54			the second client. */
55			var client2 = io.connect(socketURL, options);
56
57			client2.on('connect', function(data){
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
58			client2.emit('connection name', chatUser2);
59			});
60
61			client2.on('new user', function(usersName){
62			usersName.should.equal(chatUser2.name + " has joined.");
63			client2.disconnect();
64			});
65
66			});
67
68			var numUsers = 0;
69			client1.on('new user', function(usersName){
70			numUsers += 1;
71
72			if(numUsers === 2){
73			usersName.should.equal(chatUser2.name + " has joined.");
74			client1.disconnect();
75			done();
76			}
77			});
78			});
79
80			/* Test 3 - User sends a message to chat room. */
81			it('Should be able to broadcast messages', function(done){
82			var client1, client2, client3;
83			var message = 'Hello World';
84			var messages = 0;
85
86			var checkMessage = function(client){
87			client.on('message', function(msg){
88			message.should.equal(msg);
89			client.disconnect();
90			messages++;
91			if(messages === 3){
92			done();
93			};
94			});
95			};
96
97			client1 = io.connect(socketURL, options);
98			checkMessage(client1);
99
100			client1.on('connect', function(data){
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
101			client2 = io.connect(socketURL, options);
102			checkMessage(client2);
103
104			client2.on('connect', function(data){
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
105			client3 = io.connect(socketURL, options);
106			checkMessage(client3);
107
108			client3.on('connect', function(data){
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
109			client2.send(message);
110			});
111			});
112			});
113			});
114
115			/* Test 4 - User sends a private message to another user. */
116			it('Should be able to send private messages', function(done){
117			var client1, client2, client3;
118			var message = {to: chatUser1.name, txt:'Private Hello World'};
119			var messages = 0;
120
121			var completeTest = function(){
122			messages.should.equal(1);
123			client1.disconnect();
124			client2.disconnect();
125			client3.disconnect();
126			done();
127			};
128
129			var checkPrivateMessage = function(client){
130			client.on('private message', function(msg){
131			message.txt.should.equal(msg.txt);
132			msg.from.should.equal(chatUser3.name);
133			messages++;
134			if(client === client1){
135			/* The first client has received the message
136			we give some time to ensure that the others
137			will not receive the same message. */
138			setTimeout(completeTest, 40);
139			};
140			});
141			};
142
143			client1 = io.connect(socketURL, options);
144			checkPrivateMessage(client1);
145
146			client1.on('connect', function(data){
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
147			client1.emit('connection name', chatUser1);
148			client2 = io.connect(socketURL, options);
149			checkPrivateMessage(client2);
150
151			client2.on('connect', function(data){
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
152			client2.emit('connection name', chatUser2);
153			client3 = io.connect(socketURL, options);
154			checkPrivateMessage(client3);
155
156			client3.on('connect', function(data){
			0 ignored issues – show Unused Code introduced 2017-12-08 09:15 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
157			client3.emit('connection name', chatUser3);
158			client3.emit('private message', message)
159			});
160			});
161			});
162			});
163			});
164

ericN93 / module

Push — master ( 1d44d5...cbfa7c )

websocketTest.js ➔ describe(ꞌChat Serverꞌ) B

Complexity

Size

Duplication

Importance

6 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like